Differential D24554

Don't build static library when BUILD_TESTING=OFF
ClosedPublic
Actions

Authored by arojas on Oct 11 2019, 6:35 AM.

Details

Reviewers
apol
Group Reviewers
Frameworks
Commits
R245:f436762fb366: Don't build static library when BUILD_TESTING=OFF
Summary

Since the static library is only used for autotests, don't waste CPU cycles when not building them

Test Plan

Builds with and without BUILD_TESTING

Diff Detail

Repository
R245 Solid
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Oct 11 2019, 6:35 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 11 2019, 6:35 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
arojas requested review of this revision.Oct 11 2019, 6:35 AM
apol accepted this revision.Oct 11 2019, 9:48 AM
This revision is now accepted and ready to land.Oct 11 2019, 9:48 AM
Closed by commit R245:f436762fb366: Don't build static library when BUILD_TESTING=OFF (authored by arojas). · Explain WhyOct 11 2019, 1:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/solid/CMakeLists.txt (18 lines)

Diff 67705

View Options

src/solid/CMakeLists.txt

Loading...