Differential D24532

Declare new hash function in namespace std in order to fix build.
ClosedPublic
Actions

Authored by beischer on Oct 10 2019, 12:57 PM.

Details

Reviewers
dvratil
mwolff
Commits
R45:983cc35dd000: Declare new hash function in namespace std in order to fix build.
Summary

Fixes:

.../src/analyze/gui/parser.cpp:37:8: error: explicit specialization of ‘template<class _Tp> struct std::hash’ outside its namespace must use a nested-name-specifier [-fpermissive]

37 | struct hash<QString> {
   |        ^~~~~~~~~~~~~

seen with GCC 9.2.0 on Arch Linux.

Diff Detail

Repository
R45 Heaptrack
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
beischer requested review of this revision.Oct 10 2019, 12:57 PM
beischer created this revision.
beischer added a reviewer: mwolff.Oct 10 2019, 1:18 PM

This is a follow up of D24491.

mwolff accepted this revision.Oct 12 2019, 12:30 PM

thanks, do you have commit rights to KDE?

This revision is now accepted and ready to land.Oct 12 2019, 12:30 PM
Closed by commit R45:983cc35dd000: Declare new hash function in namespace std in order to fix build. (authored by beischer, committed by mwolff). · Explain WhyOct 13 2019, 7:27 PM
This revision was automatically updated to reflect the committed changes.
mwolff added a comment.Oct 13 2019, 7:28 PM

pushed now, thanks a lot

beischer added a comment.Oct 13 2019, 9:42 PM
In D24532#545981, @mwolff wrote:

thanks, do you have commit rights to KDE?

No I don't, so thanks for pushing the commit.

Revision Contents
Changeset List

PathPackages
Msrc/analyze/gui/parser.cpp (2 lines)

Diff 67865

View Options

src/analyze/gui/parser.cpp

Loading...