Differential D24531

[XembedSNIProxy] Scale only big icons
ClosedPublic
Actions

Authored by kmaterka on Oct 10 2019, 11:53 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Plasma: Workspaces
Commits
R120:13efbfca67f8: [XembedSNIProxy] Scale only big icons
Summary

Do not scale up small icons to avoid quality detoriation. For small icons scaling should be done in SystemTray only. Currently XembedSNIProxy scales to 32x32, then SystemTray (usually) scales it down to 24x24.

BUG: 366047
FIXED-IN: 5.17.1

Test Plan

I've run few applications with small icons:

  • keepassx (22x22)
  • liferea (16x16)
  • tuxguitar (16x16)

It looks much better without scaling in xemebdsniproxy.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kmaterka created this revision.Oct 10 2019, 11:53 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 10 2019, 11:53 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kmaterka requested review of this revision.Oct 10 2019, 11:53 AM
davidedmundson accepted this revision.Oct 10 2019, 12:01 PM
This revision is now accepted and ready to land.Oct 10 2019, 12:01 PM
ngraham edited the summary of this revision. (Show Details)Oct 10 2019, 2:36 PM
Closed by commit R120:13efbfca67f8: [XembedSNIProxy] Scale only big icons (authored by kmaterka, committed by ngraham). · Explain WhyOct 10 2019, 2:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mxembed-sni-proxy/sniproxy.cpp (2 lines)

Diff 67613

View Options

xembed-sni-proxy/sniproxy.cpp

Loading...