[Task Manager ToolTipDelegate] Let positioner size itself automatically
ClosedPublic

Authored by broulik on Aug 15 2016, 2:17 PM.

Details

Summary

Setting a Row's or Column's size to childrenRect size is just asking for trouble.
Also instead of messing with the "y" position of items within a Row, make spacing of its parent bigger which is probably what this code wanted to do in the first place.

Test Plan

No more freeze when enabling LayoutMirroring and starting

plasmashell -reverse

Tested with one window and a group, looked good.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 5937.Aug 15 2016, 2:17 PM
broulik retitled this revision from to [Task Manager ToolTipDelegate] Let positioner size itself automatically.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 15 2016, 2:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Aug 15 2016, 2:24 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Aug 15 2016, 2:24 PM
broulik updated this revision to Diff 5943.Aug 15 2016, 2:28 PM
broulik edited edge metadata.
  • Get rid of _s which is just units.smallSpacing / 2 (and only used in two places after the previous patch)
broulik updated this revision to Diff 5945.Aug 15 2016, 2:30 PM

Fix typo

This revision was automatically updated to reflect the committed changes.
hein added a subscriber: hein.Aug 23 2016, 6:40 PM

After these changes tooltips no longer have consistent heights e.g. between a window group and a single-window tooltip, which together with rendering bugs in the tooltip morphing effect makes for a horrible UX. Can you revisit this?