Differential D24509

Fix $modname in update_translations if $NOUPDATE is set
ClosedPublic
Actions

Authored by adrianchavesfernandez on Oct 9 2019, 9:35 AM.

Details

Reviewers
aacid
ltoscano
Commits
R883:1554074: Fix $modname in update_translations if $NOUPDATE is set
Test Plan

Completely untested, I simply read the code, noticed the potential issue, and refactored accordingly

Diff Detail

Branch
/trunk/l10n-kf5/scripts
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17469
Build 17487: arc lint + arc unit
adrianchavesfernandez requested review of this revision.Oct 9 2019, 9:35 AM
adrianchavesfernandez created this revision.
adrianchavesfernandez added inline comments.Oct 9 2019, 9:38 AM
update_translations
37

I moved these definitions to the beginning to make the code less error prone. It also avoids repeating a few lines to define $i and $branch.

47

Before this patch, at this point $i would be a module path instead of a module name if $NOUPDATE was defined.

aacid accepted this revision.Oct 10 2019, 8:36 PM

Same as in the other one, seens sensible, but not testing it is scary.

Up to you how much you trust yourself ;)

This revision is now accepted and ready to land.Oct 10 2019, 8:36 PM

Revision Contents
Changeset List

PathPackages
Mupdate_translations (9 lines)

Diff 67536

View Options

update_translations

Loading...