Use ECMGenerateExportHeader to manage deprecated API better
ClosedPublic
Actions

Authored by kossebau on Oct 8 2019, 1:28 PM.

Details

Reviewers

mlaurent

Group Reviewers

Frameworks

Commits

Summary

Allows

projects linking to KConfigCore/Gui to hide deprecated API up to a given version or silence deprecation warnings after a given version, using
- -DKCONFIGCORE_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKCONFIGCORE_NO_DEPRECATED
- -DKCONFIGCORE_DEPRECATED_WARNINGS_SINCE
- -DKCONFIGCORE_NO_DEPRECATED_WARNINGS
- -DKCONFIGGUI_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKCONFIGGUI_NO_DEPRECATED
- -DKCONFIGGUI_DEPRECATED_WARNINGS_SINCE
- -DKCONFIGGUI_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
to build KConfigCore/Gui optionally with deprecated API excluded from the build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

Test Plan

Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 4.0.0, 5.0.0,
5.11.0, 5.24.0, 5.39.0, 5.42.0, CURRENT.

Repository

R237 KConfig

Branch

useECMGenerateExportHeader

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17442
Build 17460: arc lint + arc unit

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.Oct 8 2019, 1:28 PM

seems ok for me

This revision is now accepted and ready to land.Oct 18 2019, 6:12 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (4 lines)
M			autotests/kconfigtest.cpp (4 lines)
M			autotests/kdesktopfiletest.h (3 lines)
M			autotests/kdesktopfiletest.cpp (2 lines)
M			src/core/CMakeLists.txt (8 lines)
M			src/core/kauthorized.h (5 lines)
M			src/core/kauthorized.cpp (2 lines)
M			src/core/kconfig.h (18 lines)
M			src/core/kconfig.cpp (4 lines)
M			src/core/kconfiggroup.h (15 lines)
M			src/core/kconfiggroup.cpp (4 lines)
M			src/core/kcoreconfigskeleton.h (44 lines)
M			src/core/kcoreconfigskeleton.cpp (25 lines)
M			src/core/kdesktopfile.h (5 lines)
M			src/core/kdesktopfile.cpp (2 lines)
M			src/core/kemailsettings.h (16 lines)
M			src/core/kemailsettings.cpp (20 lines)
M			src/gui/CMakeLists.txt (8 lines)
M			src/gui/kconfiggui.h (5 lines)
M			src/gui/kconfiggui.cpp (2 lines)
M			src/gui/kconfigloader.h (4 lines)
M			src/gui/kconfigloader.cpp (4 lines)
M			src/gui/kstandardshortcut.h (6 lines)
M			src/gui/kstandardshortcut.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	67498	db2315d		Oct 8 2019, 1:28 PM	★	★
Diff 2	67735	4c3d375	* disable KF group deprecation macros for now	Oct 11 2019, 5:37 PM	★	★
Diff 3	68261	3f68be1	R237:fb37084b3e7c396cd10bf4d3253fee730320988a	Oct 18 2019, 7:23 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
c28d796c27fd	65de89743188	db2315d79a15	Friedrich W. H. Kossebau	Use ECMGenerateExportHeader to manage deprecated API better (Show More…)	Oct 8 2019, 1:22 PM