| nienhueser | |
| rahn |
With the introduction of batymetry polygons I realized that the parsing and cutting of polygons was working on the outer boundary of the polygon, the inner rings were left out.
This patch aims to fix that, though there are some issues with this approach or I'm just missing something. When a bathymetry polygon with some inner rings is cut and then the tile loaded into Marble, the inner rings are not getting rendered, though they are there in the file.
Cutting to level 5 tiny_planet_5.1.osm and then checking tile 5/14/12
we can clearly see that even though there are lots of inner rings in the file, and the file's size is >500KB(that's pretty huge for a level 5 tile), there are barely some nodes and polygons rendered.
| Lint Skipped |
| Unit Tests Skipped |
This revision solves the issue mentioned with the bathymetry polygons missing. The problem was with the orientation of the inner rings: they are counterclockwise polygons, but the clipping algorith works ONLY on clockwise polygons, so implementing an efficient way to reverse the order of the nodes solved the problem.
Besides that, I had to track down another issue in the BaseClipper.cpp, because I noticed, that some inner rings are not even added to the files. The clipping algorithm with the TinyPlanetProcessor class works fine now, landmass polygons and bathymetry polygons too are parsed, cut and outputted correctly.