Fix crash when a modified document and not saving changes
ClosedPublic

Authored by aacid on Sun, Oct 6, 11:08 AM.

Details

Summary

If we don't delete the catalog explicitely it will be deleted in the middle of the deletion of EditorTab children.
That will cause the cleanChanged signal to be emmitted and then EditorTab::setModificationSign will be called.

Since we'll be in the middle of deleting EditorTab children very bad things can happen.

Diff Detail

Repository
R456 Lokalize
Branch
Applications/19.08
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17353
Build 17371: arc lint + arc unit
aacid requested review of this revision.Sun, Oct 6, 11:08 AM
aacid created this revision.

Looks good to me after trying a few editor tab closes with the patch and verifying that Lokalize does not crash :)

This revision is now accepted and ready to land.Mon, Oct 7, 5:23 PM
aacid closed this revision.Mon, Oct 7, 5:56 PM