Differential D24437

Fix crash when a modified document and not saving changes
ClosedPublic
Actions

Authored by aacid on Oct 6 2019, 11:08 AM.

Details

Reviewers
ltoscano
sdepiets
adrianchavesfernandez
Commits
R456:cd05ad7feb33: Fix crash when a modified document and not saving changes
Summary

If we don't delete the catalog explicitely it will be deleted in the middle of the deletion of EditorTab children.
That will cause the cleanChanged signal to be emmitted and then EditorTab::setModificationSign will be called.

Since we'll be in the middle of deleting EditorTab children very bad things can happen.

Diff Detail

Repository
R456 Lokalize
Branch
Applications/19.08
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17353
Build 17371: arc lint + arc unit
aacid requested review of this revision.Oct 6 2019, 11:08 AM
aacid created this revision.
adrianchavesfernandez accepted this revision.Oct 7 2019, 5:23 PM

Looks good to me after trying a few editor tab closes with the patch and verifying that Lokalize does not crash :)

This revision is now accepted and ready to land.Oct 7 2019, 5:23 PM
aacid closed this revision.Oct 7 2019, 5:56 PM

Revision Contents
Changeset List

PathPackages
Msrc/editortab.cpp (2 lines)

Diff 67367

View Options

src/editortab.cpp

Loading...