Explicitly define the Journal copy ctor
ClosedPublic

Authored by vkrause on Oct 3 2019, 8:43 AM.

Details

Summary

Journal has an explicitly defined assignment operator, the missing copy
ctor definition then triggers a compiler warning.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17404
Build 17422: arc lint + arc unit
vkrause requested review of this revision.Oct 3 2019, 8:43 AM
vkrause created this revision.
aacid added a comment.Oct 3 2019, 4:59 PM

hmmmm, the explicitely defined assignment operator is private (old way to delete it). So it seems what we should do is delete it and then delete the copy constructor too?

hmmmm, the explicitely defined assignment operator is private (old way to delete it). So it seems what we should do is delete it and then delete the copy constructor too?

Right, however the copy ctor is actually being used here (and seemingly correctly). I'll change the assignment operator to new style deletion though.

vkrause updated this revision to Diff 67440.Oct 7 2019, 4:25 PM

Explicitly delete the assignment operator (which has no implementation).

aacid accepted this revision.Oct 7 2019, 8:33 PM
This revision is now accepted and ready to land.Oct 7 2019, 8:33 PM
vkrause closed this revision.Oct 9 2019, 4:13 PM