src/core/job.cpp
181–182	You need a local const var to hold the result of the subjobs() method call. (repeats)
src/core/ksslcertificatemanager.cpp
408–410	`userList` would be a better variable name
src/core/ktcpsocket.cpp
729	or just iterate over `ciphers`, which is already const
src/core/scheduler.cpp
214	qAsConst not needed, this method is const
299–301	I'm afraid that kill() ends up removing the job from waitingList. I would iterate over a copy to be safe.
379	Did you try enabling this to make sure your ported code compiles?
src/widgets/dropjob.cpp
270	qAsConst
329	qAsConst
361	qAsConst
src/widgets/kdirmodel.cpp
151	qAsConst not needed, method is const
src/widgets/kfileitemdelegate.cpp
233	not needed, method is const and informationList is a member

This revision now requires changes to proceed.Oct 8 2019, 5:17 AM

Use more descriptive var names other than list2
qAsConst isn't needed if the method is const and the container is a member var

Harbormaster completed remote builds in B17451: Diff 67510.Oct 8 2019, 2:59 PM

ahmadsamir added inline comments.Oct 8 2019, 11:59 PM

src/core/job.cpp
181–182	IIUC, subjobs() returns a const QList &, do we still need a local const var? https://api.kde.org/frameworks/kcoreaddons/html/classKCompositeJob.html#aaec8d9b05c7c4194c5ba121d43f2997e
src/core/ktcpsocket.cpp
729	Yep.
src/core/scheduler.cpp
214	(... and m_runningJobs is a member var).
379	Yes, I did. (I, like everyone else, hate to be embarrassed, so I always make sure it builds and passes unittests whenever I change anything except maybe comments :)).
src/widgets/dropjob.cpp
270	m_urls is declared const in DropJobPrivate: https://cgit.kde.org/kio.git/tree/src/widgets/dropjob.cpp#n142
src/widgets/kfileitemdelegate.cpp
233	"member" is what made that concept finally click in my head; (I kept thinking calling begin() on a qt container won't call the const overload, but it will if the container is a member and the this pointer is a pointer to const).

dfaure accepted this revision.Oct 12 2019, 7:35 PM

dfaure added inline comments.

src/core/job.cpp
181–182	Well spotted. Unusual....
src/widgets/dropjob.cpp
270	Oh, interesting :-)

This revision is now accepted and ready to land.Oct 12 2019, 7:35 PM

Rebase

Harbormaster completed remote builds in B17624: Diff 67804.Oct 12 2019, 8:57 PM

I had to fix one conflict when rebasing, and basically D24419 ate the foreach src/core/ksslcertificatemanager.cpp@line 128 (in D24419, not here). By returning the result of calling contains() on the container, looks neater :).

Edit: Thanks for looking at the patch :). Should I just land it?

dfaure accepted this revision.Oct 12 2019, 9:09 PM

Closed by commit R241:7c0402ed9fd7: Compile without deprecated foreach (authored by ahmadsamir). · Explain WhyOct 12 2019, 9:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/core/batchrenamejob.cpp (2 lines)
M			src/core/connection.cpp (2 lines)
M			src/core/copyjob.cpp (4 lines)
M			src/core/desktopexecparser.cpp (5 lines)
M			src/core/job.cpp (12 lines)
M			src/core/kprotocolinfofactory.cpp (3 lines)
M			src/core/kprotocolmanager.cpp (4 lines)
M			src/core/ksslcertificatemanager.cpp (11 lines)
M			src/core/ktcpsocket.cpp (8 lines)
M			src/core/scheduler.cpp (42 lines)
M			src/core/tcpslavebase.cpp (8 lines)
M			src/urifilters/ikws/ikwsopts.cpp (2 lines)
M			src/urifilters/ikws/searchproviderdlg.cpp (2 lines)
M			src/urifilters/shorturi/kshorturifilter.cpp (2 lines)
M			src/widgets/accessmanager.cpp (3 lines)
M			src/widgets/clipboardupdater.cpp (5 lines)
M			src/widgets/delegateanimationhandler.cpp (4 lines)
M			src/widgets/dropjob.cpp (8 lines)
M			src/widgets/kdesktopfileactions.cpp (3 lines)
M			src/widgets/kdirmodel.cpp (6 lines)
M			src/widgets/kfileitemactions.cpp (5 lines)
M			src/widgets/kfileitemdelegate.cpp (4 lines)
M			src/widgets/kpropertiesdialog.cpp (10 lines)
M			src/widgets/krun_win.cpp (2 lines)
M			src/widgets/ksslcertificatebox.cpp (3 lines)
M			src/widgets/ksslinfodialog.cpp (5 lines)
M			src/widgets/kurifiltersearchprovideractions.cpp (2 lines)
M			src/widgets/previewjob.cpp (4 lines)
M			src/widgets/sslui.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	67217	9713ea0		Oct 2 2019, 8:14 PM	★	★
Diff 2	67510	6d8bd6f	- User more descriptive var names other than list2	Oct 8 2019, 2:59 PM	★	★
Diff 3	67804	41a209b	Rebase	Oct 12 2019, 8:57 PM	★	★
Diff 4	67808	41a209b	R241:7c0402ed9fd7b3a0c8d0ba1191b70e72f73aaa73	Oct 12 2019, 9:17 PM	★	★