- R241:7c0402ed9fd7: Compile without deprecated foreach
make && ctest
You need a local const var to hold the result of the subjobs() method call.
userList would be a better variable name
or just iterate over ciphers, which is already const
qAsConst not needed, this method is const
I'm afraid that kill() ends up removing the job from waitingList. I would iterate over a copy to be safe.
Did you try enabling this to make sure your ported code compiles?
qAsConst not needed, method is const
not needed, method is const and informationList is a member
IIUC, subjobs() returns a const QList &, do we still need a local const var?
(... and m_runningJobs is a member var).
Yes, I did. (I, like everyone else, hate to be embarrassed, so I always make sure it builds and passes unittests whenever I change anything except maybe comments :)).
m_urls is declared const in DropJobPrivate: https://cgit.kde.org/kio.git/tree/src/widgets/dropjob.cpp#n142
"member" is what made that concept finally click in my head; (I kept thinking calling begin() on a qt container won't call the const overload, but it will if the container is a member and the this pointer is a pointer to const).