Differential D2433

Display selected, newly created tags
ClosedPublic
Actions

Authored by dkurz on Aug 13 2016, 11:24 AM.

Details

Reviewers
knauss
Group Reviewers
KDE PIM
Commits
R165:7997c450984e: Display selected, newly created tags
Summary

In some cases, it is necessary to set newly created tags as selected for the
TagView. The text field in TagView only displays tags that are part of its
TagModel. This change allows TagWidget to update its view when selected tags
that did not exist initially were added to the TagModel.

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dkurz updated this revision to Diff 5890.Aug 13 2016, 11:24 AM
dkurz retitled this revision from to Display selected, newly created tags.
dkurz updated this object.
dkurz edited the test plan for this revision. (Show Details)
dkurz added a reviewer: KDE PIM.
dkurz set the repository for this revision to R165 Akonadi .
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 13 2016, 11:24 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
knauss added a subscriber: knauss.Aug 14 2016, 9:53 AM

looks fine

knauss accepted this revision.Aug 14 2016, 9:53 AM
knauss added a reviewer: knauss.
This revision is now accepted and ready to land.Aug 14 2016, 9:53 AM
tillschafer added a subscriber: tillschafer.Aug 16 2016, 2:28 PM

tested this changes in combination with https://phabricator.kde.org/D2423 on 16.07.90 and it works like a charm.
-> creation/modification of an event on one client with a new tag name, synchronized them over the DAV resource, look at new/changed event on another client. New tags are correctly created.

dkurz added a comment.Aug 19 2016, 9:06 AM

I don't have commit access. Would someone please push this for me?

Closed by commit R165:7997c450984e: Display selected, newly created tags (authored by Denis Kurtz <denis.kurtz@posteo.de>, committed by dvratil). · Explain WhyAug 26 2016, 1:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/tagwidget.cpp (1 line)

Diff 6298

View Options

src/widgets/tagwidget.cpp

Loading...