Don't compute frame extents in packPositionFoo methods
ClosedPublic
Actions

Authored by zzag on Oct 1 2019, 12:59 PM.

Details

Reviewers

None

Group Reviewers

KWin

Commits

Summary

Use frameMargins() method instead.

Repository

R108 KWin

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 17208
Build 17226: arc lint + arc unit

Restricted Application added a project: KWin. · View Herald TranscriptOct 1 2019, 12:59 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Oct 1 2019, 12:59 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 2 2019, 9:40 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			placement.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	67128	9e84cfc		Oct 1 2019, 12:59 PM	★	★
Diff 2	67176	1f301b2	R108:68cbbb62f0eb3ed88d26003b2b7329a889161cb9	Oct 2 2019, 8:46 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
898095079071	4b17a62d9c82	9e84cfcfe589	Vlad Zahorodnii	Don't compute frame extents in packPositionFoo methods (Show More…)	Sep 28 2019, 3:37 PM

Status	Author	Revision
Closed	zzag	D24338 Document some geometry properties
Closed	zzag	D24336 Don't compute frame extents in packPositionFoo methods
Closed	zzag	D24335 Fix coding style issues in window packing code
Closed	zzag	D24334 Rename geometry property to frameGeometry
Closed	zzag	D24332 [wayland] Get rid of some code duplication in XdgShellClient constructors
Closed	zzag	D24331 [wayland] Fix some coding style issues in setGeometry method
Closed	zzag	D24330 [wayland] Add missing const qualifier in resizeWithChecks
Closed	zzag	D24329 [wayland] Use setGeometry in resizeWithChecks
Closed	zzag	D24328 [wayland] Process pending state and map the client on commit