Document known issue in Recurrence::operator=
ClosedPublic

Authored by vkrause on Sep 30 2019, 8:31 PM.

Details

Summary

Found by Albert. Could be fixed properly as well, but it turns out this
is entirely unused (ie. things build with operator= marked as deleted).
Deleting it however is a change we cannot apply anymore without breaking
ABI.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17186
Build 17204: arc lint + arc unit
vkrause requested review of this revision.Sep 30 2019, 8:31 PM
vkrause created this revision.
aacid added a comment.Sep 30 2019, 8:53 PM

is ABI a problem? we haven't released this thing yet? or have we?

is ABI a problem? we haven't released this thing yet? or have we?

From a pure KF5 perspective that is correct. However to ease the transition from Applications to Frameworks we made the promise that the first KF5 release would be a drop-in replacement for the last Application release. Removing the op= symbol would break that promise, and since there are "users" of the symbol (which are dead code, see D24319 and D24320), it nevertheless would break dynamic linking.

aacid accepted this revision.Oct 1 2019, 5:39 PM

OK :/

This revision is now accepted and ready to land.Oct 1 2019, 5:39 PM
vkrause closed this revision.Oct 3 2019, 8:28 AM