Differential D24304

[Cuttlefish] Add 48 to the sizeslider
ClosedPublic
Actions

Authored by davidre on Sep 30 2019, 10:16 AM.

Details

Reviewers
cblack
ngraham
Group Reviewers
Plasma
Commits
R118:37763ba7b84d: [Cuttlefish] Add 48 to the sizeslider
Summary

The initial icon size Cuttlefish starts with is 48 (Kirigami.Unis.iconSizes.large).
However this size cannot be selected using the slider. To quickly see this
start Cuttlefish (note the slider says 64) and move the slide to some other
value and back to 64. The icons have now a different size than before. Since we
also show a preview for 48 add this size to the selectable ones.

Diff Detail

Repository
R118 Plasma SDK
Branch
48 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17165
Build 17183: arc lint + arc unit
davidre created this revision.Sep 30 2019, 10:16 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 30 2019, 10:16 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidre requested review of this revision.Sep 30 2019, 10:16 AM
ngraham accepted this revision.Sep 30 2019, 3:41 PM
This revision is now accepted and ready to land.Sep 30 2019, 3:41 PM
Closed by commit R118:37763ba7b84d: [Cuttlefish] Add 48 to the sizeslider (authored by davidre). · Explain WhyOct 1 2019, 12:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 67052

View Options

cuttlefish/package/contents/ui/Tools.qml

Loading...
View Options

cuttlefish/package/contents/ui/cuttlefish.qml

Loading...