Differential D2427

[Applet Configuration] Don't ask for saving changes when clicking current category
ClosedPublic
Actions

Authored by broulik on Aug 12 2016, 3:11 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R119:9e8ff49b57ca: [Applet Configuration] Don't ask for saving changes when clicking current…
Summary

When changing some setting and then clicking the current category in the sidebar it wouldn't switch as we're already on that page but it would still ask whether we want to save our changes. This makes no sense.

Test Plan

Opened applet config, changed something, clicked on same category. Nothing happened. Clicked on other setting, dialog asked whether I would like to save my changes appeared.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 5880.Aug 12 2016, 3:11 PM
broulik retitled this revision from to [Applet Configuration] Don't ask for saving changes when clicking current category.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 12 2016, 3:11 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Aug 13 2016, 11:12 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Aug 13 2016, 11:12 AM
Closed by commit R119:9e8ff49b57ca: [Applet Configuration] Don't ask for saving changes when clicking current… (authored by broulik). · Explain WhyAug 14 2016, 10:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5905

View Options

desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

Loading...