[effects/presentwindows] Port present windows to EffectQuickView

Authored by davidedmundson on Sep 26 2019, 12:17 PM.



Removes over 100 lines of rather confusing code, implicitly introduces a
sharedEngine. Doesn't perform hide/show by moving a window offscreen.

As for the freeze, proving that EffectQuickView covers this case without
lots of extra C++ is an important pre-requisite for ever moving this
effect to a magic declarative API.

General code structure remains the same.

Test Plan

Opened present windows

Diff Detail

R108 KWin
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: KWin. · View Herald TranscriptSep 26 2019, 12:17 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Sep 26 2019, 12:17 PM
zzag added a subscriber: zzag.Sep 27 2019, 10:57 AM
zzag added inline comments.

Shouldn't it stay?

zzag added inline comments.Sep 27 2019, 11:03 AM


This can potentially segfault if the user unchecked "Provide buttons to close the windows" in pw kcm.

davidedmundson marked 2 inline comments as done.


zzag added a comment.Oct 17 2019, 6:29 PM

Is it just me or the close button doesn't have background anymore? I have Qt 5.14.

zzag accepted this revision.Oct 17 2019, 6:31 PM

Hmm, nevermind, that issue is present even in master.

This revision is now accepted and ready to land.Oct 17 2019, 6:31 PM

I have Qt 5.14.

You'll find all your SVGs will break soon. It's a known bug.

zzag added a comment.Oct 17 2019, 7:01 PM

your SVGs will break soon

Heh, that sounds reassuring. :-)

This revision was automatically updated to reflect the committed changes.