Differential D24240

[effects/presentwindows] Port present windows to EffectQuickView
ClosedPublic
Actions

Authored by davidedmundson on Sep 26 2019, 12:17 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:cd99a901f601: [effects/presentwindows] Port present windows to EffectQuickView
Summary

Removes over 100 lines of rather confusing code, implicitly introduces a
sharedEngine. Doesn't perform hide/show by moving a window offscreen.

As for the freeze, proving that EffectQuickView covers this case without
lots of extra C++ is an important pre-requisite for ever moving this
effect to a magic declarative API.

General code structure remains the same.

Test Plan

Opened present windows

Diff Detail

Repository
R108 KWin
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 17796
Build 17814: arc lint + arc unit
Restricted Application added a project: KWin. · View Herald TranscriptSep 26 2019, 12:17 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Sep 26 2019, 12:17 PM
zzag added a subscriber: zzag.Sep 27 2019, 10:57 AM
zzag added inline comments.
effects/presentwindows/presentwindows.cpp
533

Shouldn't it stay?

zzag added inline comments.Sep 27 2019, 11:03 AM
effects/presentwindows/presentwindows.cpp
238

m_closeView->isVisible()

This can potentially segfault if the user unchecked "Provide buttons to close the windows" in pw kcm.

davidedmundson updated this revision to Diff 68122.Oct 17 2019, 11:01 AM
davidedmundson marked 2 inline comments as done.

update

zzag added a comment.Oct 17 2019, 6:29 PM

Is it just me or the close button doesn't have background anymore? I have Qt 5.14.

zzag accepted this revision.Oct 17 2019, 6:31 PM

Hmm, nevermind, that issue is present even in master.

This revision is now accepted and ready to land.Oct 17 2019, 6:31 PM
davidedmundson added a comment.Oct 17 2019, 6:49 PM

I have Qt 5.14.

You'll find all your SVGs will break soon. It's a known bug.

zzag added a comment.Oct 17 2019, 7:01 PM

your SVGs will break soon

Heh, that sounds reassuring. :-)

Closed by commit R108:cd99a901f601: [effects/presentwindows] Port present windows to EffectQuickView (authored by davidedmundson). · Explain WhyOct 21 2019, 2:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 68122

View Options

effects/presentwindows/main.qml

Loading...
View Options

effects/presentwindows/presentwindows.h

Loading...
View Options

effects/presentwindows/presentwindows.cpp

Loading...