Differential D2420

[Task Manager] Fix icon placement with right-to-left languages
ClosedPublic
Actions

Authored by broulik on Aug 12 2016, 11:09 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:7034546fefe1: [Task Manager] Fix icon placement with right-to-left languages
Summary

X and Y coordinates are not mirrored by LayoutMirroring. Instead, just use anchors and let Qt figure it out.

Test Plan

Started

plasmashell -reverse

Icon appeared on the right of text rather than overlapping it

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 5868.Aug 12 2016, 11:09 AM
broulik retitled this revision from to [Task Manager] Fix icon placement with right-to-left languages.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 12 2016, 11:09 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Aug 15 2016, 10:26 AM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Aug 15 2016, 10:26 AM
Closed by commit R119:7034546fefe1: [Task Manager] Fix icon placement with right-to-left languages (authored by broulik). · Explain WhyAug 15 2016, 11:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5924

View Options

applets/taskmanager/package/contents/ui/Task.qml

Loading...