Differential D24198

[wayland] Fix some coding style issues in XdgShellClient
ClosedPublic
Actions

Authored by zzag on Sep 24 2019, 2:50 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:0cacd9dc0a2a: [wayland] Fix some coding style issues in XdgShellClient
Summary

The Frameworks coding style prohibits using short variable names, unless
it's a counter in a loop.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Sep 24 2019, 2:50 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 24 2019, 2:50 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Sep 24 2019, 2:50 PM
davidedmundson accepted this revision.Sep 24 2019, 3:11 PM
davidedmundson added a subscriber: davidedmundson.

That's a misquote of the spec. It says

Single character variable names can denote counters and temporary variables whose purpose is obvious

I think these counted as temporary things - but this isn't any worse either.

This revision is now accepted and ready to land.Sep 24 2019, 3:11 PM
zzag added a comment.Sep 24 2019, 3:19 PM
In D24198#537136, @davidedmundson wrote:

That's a misquote of the spec. It says

Single character variable names can denote counters and temporary variables whose purpose is obvious

I think these counted as temporary things - but this isn't any worse either.

Frameworks coding style is vague about temporary variables. One could argue that practically each variable in a method or a function is temporary. ;-)

Closed by commit R108:0cacd9dc0a2a: [wayland] Fix some coding style issues in XdgShellClient (authored by zzag). · Explain WhySep 26 2019, 9:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mxdgshellclient.cpp (19 lines)

Diff 66881

View Options

xdgshellclient.cpp

Loading...