Differential D24192

WIP: Active page follow the focus
Needs ReviewPublic
Actions

Authored by ognarb on Sep 24 2019, 2:10 PM.

Details

Reviewers
None
Group Reviewers
Kirigami
Plasma Accessibility
Summary

This doesn't work well yet.

  • Need a long time (2-4 seconde) before the page is updated
  • Loss focus after changing page

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16967
Build 16985: arc lint + arc unit
ognarb created this revision.Sep 24 2019, 2:10 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptSep 24 2019, 2:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ognarb requested review of this revision.Sep 24 2019, 2:10 PM
ognarb added a subscriber: mart.Sep 24 2019, 2:13 PM
ognarb added inline comments.
src/controls/PageRow.qml
172

@mart removePage doesn't work well, how can I change the current page?

broulik added a subscriber: broulik.Sep 24 2019, 3:01 PM
broulik added inline comments.
src/controls/PageRow.qml
162

Does this work in Qt 5.11? I recall typeof for QML types only being implemented in Qt 5.12

mart added inline comments.Oct 16 2019, 8:05 AM
src/controls/PageRow.qml
162

i kinda remind instanceof was added in 5.10 tough was buggy or something like that
it needs someone actually testing it on Qt 5.11

mart added a comment.Oct 22 2019, 6:00 PM

loses the focus after changing page because when current item changes, it sets focus to the page, which probably isn't set as focus scope

src/controls/PageRow.qml
172

what do you mean with doesn't work well?
anywaus, you should just set the current index, not removing anything from the row. it's a destructive action that should never happen automatically

mart added a comment.Jan 13 2020, 1:11 PM

any update on it?

Revision Contents
Changeset List

PathPackages
Msrc/controls/PageRow.qml (25 lines)

Diff 66756

View Options

src/controls/PageRow.qml

Loading...