After D2281 set the stage, this change drops the C++ label in favor
of the PlasmaComponents-based label added then. A consensus has
emerged that the things the C++ label did that the new label does
not do (fadeout gradients, shadowing) are not actually desirable.
Details
Details
- Reviewers
broulik - Group Reviewers
Plasma - Commits
- R119:6c3b01c52f4a: Drop the C++ text label implementation.
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Fixes:
- Bug 346050: No subpixel rendering in task manager
- Bug 360119: Task manager text is blurry
and because we no longer have a shadow to begin with:
- Bug 357242: se theme-defined color for task label shadow
| applets/taskmanager/package/contents/ui/Task.qml | ||
|---|---|---|
| 390 | Should we perhaps keep the Loader for optimizing the icon-tasks case, or does that introduce too much overhead/code maintenance? | |
| applets/taskmanager/package/contents/ui/Task.qml | ||
|---|---|---|
| 390 | I think it's a wash. If we add the Loader, we have an extra QObject, an extra QML file, it adds instanciation latency and needs more disk I/O and parsing work. An invisible label isn't that heavy I think :). | |