Differential D24152

Guiding Labels
ClosedPublic
Actions

Authored by lancaster on Sep 22 2019, 10:28 PM.

Details

Reviewers
mutlaqja
Commits
R321:b6eeb8928b84: Guiding Labels
Summary

Merge remote-tracking branch 'refs/remotes/origin/master'

Merge remote-tracking branch 'refs/remotes/origin/master'

Merge branch 'master' of https://github.com/KDE/kstars

Diff Detail

Repository
R321 KStars
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16897
Build 16915: arc lint + arc unit
lancaster requested review of this revision.Sep 22 2019, 10:28 PM
lancaster created this revision.
mutlaqja requested changes to this revision.Sep 23 2019, 4:35 AM

Looking good, just simple i18n change.

kstars/ekos/guide/guide.cpp
268 ↗(On Diff #66634)

Please use i18nc for context. i.e.

i18nc("North", "N")

This revision now requires changes to proceed.Sep 23 2019, 4:35 AM
lancaster updated this revision to Diff 66640.Sep 23 2019, 4:43 AM

Improving Translations

mutlaqja accepted this revision.Sep 23 2019, 4:45 AM
This revision is now accepted and ready to land.Sep 23 2019, 4:45 AM
Closed by commit R321:b6eeb8928b84: Guiding Labels (authored by lancaster, committed by mutlaqja). · Explain WhySep 23 2019, 4:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 66640

View Options

kstars/ekos/guide/guide.h

Loading...
View Options

kstars/ekos/guide/guide.cpp

Loading...