Differential D24129

Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview
ClosedPublic
Actions

Authored by GB_2 on Sep 21 2019, 9:10 AM.

Details

Reviewers
ngraham
romangg
Group Reviewers
Plasma
VDG
Commits
R104:ff0ac9ab879d: Fix clipping and use a real ScrollView for the Display Configuration KCM screen…
Summary


The old rectangle was completely white, even in dark themes and wasn't completely consistent.

Test Plan

Open the Display Configuration KCM.

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Sep 21 2019, 9:10 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 21 2019, 9:10 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Sep 21 2019, 9:10 AM
GB_2 updated this revision to Diff 66577.Sep 21 2019, 9:10 AM

Fix more

GB_2 edited the test plan for this revision. (Show Details)Sep 21 2019, 9:10 AM
ngraham added a subscriber: ngraham.Sep 21 2019, 2:52 PM
ngraham added inline comments.
kcm/package/contents/ui/Screen.qml
51

You actually don't need these two lines, because a framed scrollview uses the view background color by default anyway

GB_2 updated this revision to Diff 66614.Sep 22 2019, 12:17 PM

Remove unneeded lines

GB_2 marked an inline comment as done.Sep 22 2019, 12:18 PM
ngraham accepted this revision.Sep 22 2019, 12:59 PM
ngraham added a subscriber: romangg.

Looks like Plasma/5.17 material to me. @romangg, do you agree?

This revision is now accepted and ready to land.Sep 22 2019, 12:59 PM
romangg accepted this revision.Sep 26 2019, 5:27 PM

Yea, 5.17. Thanks!

Closed by commit R104:ff0ac9ab879d: Fix clipping and use a real ScrollView for the Display Configuration KCM screen… (authored by GB_2). · Explain WhySep 27 2019, 12:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 66942

View Options

kcm/package/contents/ui/Output.qml

Loading...
View Options

kcm/package/contents/ui/Screen.qml

Loading...