Toggle button colors are now correct.
I was actually just about to report this, hah. The text color for the checked state looks too light for Breeze and Breeze light though:
The Breeze Widget theme has this using a dark text color instead of a light one. The color appears to be correct for Breeze Dark though.
This is because the default button uses the View Background color. On Breeze Dark, the default button is much more obvious:
I still agree that blue would be better for the default button.
Yeah, it's definitely more obvious in Breeze dark, but I've always felt that a more colorful color was appropriate for the default button. Maybe it's just my history in macOS, where it's been like that for 20 years, but I've always appreciated being able to visually pick out in an instant what button the programmers wanted to highlight as the obvious or safe choice. GNOME does this too in some apps, using a bright blue button color to help guide you through a UI. See SimpleScan for example.
I'd rather not diverge from the Breeze here for a few reasons:
- I don't have a guarantee that Breeze is going to have the exact same change
- Breeze GTK is supposed to look like the current state of Breeze, with adaptations where necessary due to differences between GTK and Qt
If Breeze gets the change, I'll add it.
I will do the same thing to Breeze if I ever find an example of a situation where a focusable and toggleable button exists with the same usability issue. We do have a real example where this usability issue happens with GTK, so I think it's best to do this now instead of later.
@cblack if we're going to use this patch to do that, then the same treatment needs to be done for other buttonlike controls like comboboxes (with and without text entry), font buttons, file picker buttons, etc. Also I feel like maybe the border thickness of the highlight could stand to be increased so it's more visible.
@ndavis, if we're going to do this, can you make the same change in Breeze itself so the themes are consistent?