Revert "Revert "i18n fixes""
ClosedPublic

Authored by ltoscano on Sep 19 2019, 10:59 AM.

Details

Summary

As translator, any supposed arbitrary coding style which
breaks the translation is not acceptable.
We can certainly discuss the proper long term solution
about fixing the coding style, about fixing QML, about
fixing gettext, or any other fix, but knowingly
breaking the translations is not acceptable.

We can certainly discuss after.

This reverts commit b5fc1a7619ad851c50a7969ab029c2592727b068.

Test Plan

Transltions works.

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ltoscano created this revision.Sep 19 2019, 10:59 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 19 2019, 10:59 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ltoscano requested review of this revision.Sep 19 2019, 10:59 AM

As said in the revert if currently there is no other way of making translations of long sentences work in QML while respecting the line chars limit this needs to go in of course.

I would like to see this resolved long-term such that:

  • Translations work of course.
  • Code always respects the 100 chars limit. If we do exceptions for translated strings because of technical problems this will dilute the rule and likely lead to code not respecting it at all.

Could something like this work:

i18n(Lorem ipsum dolor sit amet, consectetur adipisici elit,\
     sed eiusmod tempor incidunt ut labore et dolore magna aliqua.)

Or should/could we make the one with + work? Who wrote the original QML translation capabilities and could he/she give some input on this issue? Would be nice to see a path forward before doing the re-revert.

bshah added a subscriber: bshah.Sep 19 2019, 11:19 AM

As mentioned on IRC, +1 to this patch. If this violates a coding style, we can discuss it in the mailing-list/IRC later and either

  • come up with solution to this affecting translations
  • come up with exception

and make change accordingly, but let's try to not block a release on this. I am not marking this as accepted, but would be preferred to get this accepted.

romangg accepted this revision.Sep 19 2019, 11:34 AM

Ok, to not block the release translations any longer I accept this as a short-term solution and created task T11721 on Kirigami board about this issue and hope a long-term solution can be found there. Would be nice if translation team can provide input there.

This revision is now accepted and ready to land.Sep 19 2019, 11:34 AM
This revision was automatically updated to reflect the committed changes.