Make KColorScheme compatible with QVariant
ClosedPublic
Actions

Authored by vkrause on Sep 18 2019, 6:01 PM.

Details

Reviewers

dfaure

Maniphest Tasks

T8837: QColor support for Grantlee

Commits

Summary

This requires default constructability and a meta type declaration. The
use-case for this is to expose a KColorScheme instance to Grantlee.

Repository

R265 KConfigWidgets

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

vkrause requested review of this revision.Sep 18 2019, 6:01 PM

Does this break source compatibility with code currently doing Q_DECLARE_METATYPE(KColorScheme) already?

In D24060#534122, @dfaure wrote:

Does this break source compatibility with code currently doing Q_DECLARE_METATYPE(KColorScheme) already?

No, as Q_DECLARE_METATYPE requires the type to have a default ctor, which it did not have until now.

Haha that's lucky!

This revision is now accepted and ready to land.Sep 18 2019, 7:50 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/kcolorscheme.h (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	66401	a181746		Sep 18 2019, 6:01 PM	★	★
Diff 2	66490	a181746	R265:d65940d8e882535971dc528277b176a6567c69c1	Sep 19 2019, 5:32 PM	★	★

	Status	Author	Revision
	Closed	vkrause	D24094 Add support for KColorScheme
	Closed	vkrause	D24060 Make KColorScheme compatible with QVariant