Differential D23995

[KComboBox] Properly disable Qt's builtin completer [regression fix]
ClosedPublic
Actions

Authored by dfaure on Sep 16 2019, 2:02 PM.

Details

Reviewers
broulik
Commits
R284:be5bfbe82b9b: [KComboBox] Properly disable Qt's builtin completer [regression fix]
Summary

It is set by setLineEdit when the deprecated bool autoCompletion hasn't
previously been set to false. So the commit that removed
setAutoCompletion(false) led to an unwanted QCompleter, indirectly.

Test Plan

kfind's "Look in" combobox no longer offers completion
from the combo items (preselected, in the lineedit)

Diff Detail

Repository
R284 KCompletion
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16631
Build 16649: arc lint + arc unit
dfaure created this revision.Sep 16 2019, 2:02 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 16 2019, 2:02 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Sep 16 2019, 2:02 PM
broulik accepted this revision.Sep 16 2019, 2:20 PM

Thanks

This revision is now accepted and ready to land.Sep 16 2019, 2:20 PM
dfaure closed this revision.Sep 16 2019, 2:22 PM

Revision Contents
Changeset List

PathPackages
Msrc/kcombobox.cpp (6 lines)

Diff 66225

View Options

src/kcombobox.cpp

Loading...