Differential D23991

GIT_SILENT fix comment about passwords in debug output
ClosedPublic
Actions

Authored by ahmadsamir on Sep 16 2019, 1:16 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:9c04b125efd5: GIT_SILENT fix comment about passwords in debug output
Summary

QUrls in debug output always have the password removed (upstream impl.)

Diff Detail

Repository
R241 KIO
Branch
ahmad/url-debug-output-passwords (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16633
Build 16651: arc lint + arc unit
ahmadsamir created this revision.Sep 16 2019, 1:16 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 16 2019, 1:16 PM
ahmadsamir requested review of this revision.Sep 16 2019, 1:16 PM
dfaure accepted this revision.Sep 16 2019, 1:20 PM

There isn't even a QString around in this code, so you could just remove the comment altogether.

This revision is now accepted and ready to land.Sep 16 2019, 1:20 PM
ahmadsamir updated this revision to Diff 66227.Sep 16 2019, 2:22 PM

Remove redundant comments

dfaure accepted this revision.Sep 16 2019, 2:23 PM
dfaure closed this revision.Sep 16 2019, 2:24 PM

Revision Contents
Changeset List

PathPackages
Msrc/core/kcoredirlister.cpp (3 lines)

Diff 66227

View Options

src/core/kcoredirlister.cpp

Loading...