Differential D23983

[Notifications] Create KFilePlacesModel when needed
ClosedPublic
Actions

Authored by broulik on Sep 16 2019, 7:40 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R120:935318dffd3d: [Notifications] Create KFilePlacesModel when needed
Summary

A job instance is created as soon as the job starts but it might not be shown to the user right away or at all.
JobPrivate::prettyDestUrl() already creates the KFilePlacesModel if needed, no need to do it in the constructor.

Test Plan
  • Started a file copy, got the KFilePlacesModel created only after 500ms when the copy dialog showed up

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 16 2019, 7:40 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 16 2019, 7:40 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 16 2019, 7:40 AM
apol accepted this revision.Sep 16 2019, 10:04 AM
This revision is now accepted and ready to land.Sep 16 2019, 10:04 AM
Closed by commit R120:935318dffd3d: [Notifications] Create KFilePlacesModel when needed (authored by broulik). · Explain WhySep 16 2019, 10:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibnotificationmanager/job_p.cpp (1 line)

Diff 66197

View Options

libnotificationmanager/job_p.cpp

Loading...