Differential D23965

[Dolphin] Add icons for "Go" and "Tools"
AbandonedPublic
Actions

Authored by tienisto on Sep 15 2019, 1:10 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Summary

This commit adds missing icons for "Go" and "Tools" in the control menu

Test Plan

Open the control menu, you will see two new icons for "Go" and "Tools"

Diff Detail

Repository
R318 Dolphin
Branch
go-and-tools-icons (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16581
Build 16599: arc lint + arc unit
tienisto created this revision.Sep 15 2019, 1:10 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptSep 15 2019, 1:10 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
tienisto requested review of this revision.Sep 15 2019, 1:10 PM
tienisto edited the summary of this revision. (Show Details)Sep 15 2019, 1:14 PM
tienisto added a reviewer: ngraham.
tienisto retitled this revision from Add icons for "Go" and "Tools" to [Dolphin] Add icons for "Go" and "Tools".Sep 15 2019, 1:18 PM
ngraham requested changes to this revision.Sep 15 2019, 1:20 PM

I'm afraid you're slightly too late! :) I just removed those menus from the hamburger menu entirely, replacing them with curated subsets of their content. Rebase on master and you'll see.

Also, the correct place to add icons for these menus would be in the dolphinui.rc file.

This revision now requires changes to proceed.Sep 15 2019, 1:20 PM
tienisto abandoned this revision.Sep 15 2019, 1:55 PM

Okay, I've seen your change. Well, those 2 icons are not needed anymore I think.

ngraham added a comment.Sep 15 2019, 4:24 PM

No worries! And sorry for rejecting your first patch. D23969 looks much more promising. :)

Revision Contents
Changeset List

PathPackages
Msrc/dolphinmainwindow.cpp (2 lines)

Diff 66125

View Options

src/dolphinmainwindow.cpp

Loading...