Differential D23913

[kcmkwin/kwineffects] Use new Kirigami ListSectionHeader component
ClosedPublic
Actions

Authored by GB_2 on Sep 12 2019, 5:17 PM.

Details

Reviewers
davidedmundson
ngraham
Group Reviewers
KWin
Plasma
VDG
Commits
R108:f40638f46ba3: [kcmkwin/kwineffects] Use new Kirigami ListSectionHeader component
Summary

Test Plan

Open the Desktop Effects KCM.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Sep 12 2019, 5:17 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 12 2019, 5:17 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
GB_2 requested review of this revision.Sep 12 2019, 5:17 PM
davidedmundson accepted this revision.Sep 12 2019, 5:28 PM
This revision is now accepted and ready to land.Sep 12 2019, 5:28 PM
ngraham added a subscriber: ngraham.Sep 12 2019, 6:12 PM
ngraham added inline comments.
kcmkwin/kwineffects/package/contents/ui/Effect.qml
67 ↗(On Diff #65939)

Are you sure about this change? Semantically, it is indeed a heading. If the purpose of this was to make the list item headings smaller than the section headers by using a Label, you can keep it as a Heading but raise the level to 5, which has the same size as a Label.

GB_2 updated this revision to Diff 65938.Sep 12 2019, 6:16 PM

Use Heading level 5

GB_2 marked an inline comment as done.Sep 12 2019, 6:16 PM
ngraham accepted this revision.Sep 12 2019, 6:18 PM
Closed by commit R108:f40638f46ba3: [kcmkwin/kwineffects] Use new Kirigami ListSectionHeader component (authored by GB_2). · Explain WhySep 12 2019, 6:29 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 65939