Differential D23897

Port mobile_wifi kcm to newer APIs
ClosedPublic
Actions

Authored by jbbgameich on Sep 12 2019, 10:40 AM.

Details

Reviewers
jgrulich
nicolasfella
Group Reviewers
Plasma: Mobile
Commits
R116:4ca3d7aa14c7: Port mobile_wifi kcm to newer APIs
Summary
  • Controls.Button can display icons on its own now
  • Use kcm.push() and kcm.pop()
  • Use Kirigami.ListSectionHeader instead of custom code

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jbbgameich created this revision.Sep 12 2019, 10:40 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 12 2019, 10:40 AM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jbbgameich requested review of this revision.Sep 12 2019, 10:40 AM
nicolasfella accepted this revision.Sep 16 2019, 7:07 PM

Looks good to me.

Jan agreed that we can land patches to the mobile stuff without his approval

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2019, 7:18 PM
Closed by commit R116:4ca3d7aa14c7: Port mobile_wifi kcm to newer APIs (authored by jbbgameich). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 66259

View Options

mobile/wifi/package/contents/ui/ConnectionEditor.qml

Loading...
View Options

mobile/wifi/package/contents/ui/TetheringSetting.qml

Loading...
View Options

mobile/wifi/package/contents/ui/main.qml

Loading...