Introduce a new page to the Account Wizard where user can select a cryptographic key to be set to the newly created identity. Use can also generate a new key pair or import an existing key from file.
The page follows the Personal Data page and is only shown when the Personal Data page is enabled.
I'm wondering if I should maybe move the "Always sign/always encrypt/never sign/...." combobox from the Personal Data page to the Crypto page, since it's crypto-related...?
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| accountwizard/src/cryptopage.cpp | ||
|---|---|---|
| 47 | I don't think so. The class is a bit misnamed but the main thing the code here does imo is create a backend job and adds error and success handling. The one thing I see that we could put in libkleo / qgpgme would be API to have a "defaultKeyGenerationJob" that takes name and email as arguments and otherwise used default parameters. So that we have default parameters in a central place and can do the version check what kind of defaults gnupg accepts. e.g. newer version accept key-type: default key-length: default etc. and 2.1 even has an --quick-gen-key that only takes name and email and does not need params at all. | |
| accountwizard/src/dialog.cpp | ||
| 62 | I think we need to check if GnuPG is installed here, as it's optional for KMail? An "if (!GpgME::checkEngine(GpgME::OpenPGP))" should do the trick. Otherwise the other jobs will result in errors. | |
| accountwizard/src/cryptopage.cpp | ||
|---|---|---|
| 47 | Yeah, the overall KeyGenerationJob is a wrapper that wraps key generation + key realoding into a single Kleo::Job that can be bound to the ProgressDialog. I'd like to hide the XML into a job in libkleo though. Maybe it would even make sense to have a more complex job that allows specifying all kinds of arguments, subkeys etc. and would generate the XML internally. | |
| accountwizard/src/cryptopage.cpp | ||
|---|---|---|
| 47 | Jep, key generation is a bit horrible in gpgme ( https://bugs.gnupg.org/gnupg/issue2280 ) A more complex meta job is something I'd like to have for Kleopatra as one thing I think is really a must have feature is to generate keys with multiple UID's which the API currently does not cover. | |
Feedback I got after some testing:
Both issues has been addressed in 16.12 and master branches of kmail-account-wizard.