Share logic for passing AbstractTasksModelIface methods to source model
ClosedPublic
Actions

Authored by davidedmundson on Aug 9 2016, 11:22 AM.

Details

Reviewers

Group Reviewers

Commits

Summary

Create a subclass of AbstractTasksModelIface which proxies the call to
the source model.

All proxy models can then re-use this rather than duplicating the code

Test Plan

Clicked some things

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson retitled this revision from to Share logic for passing AbstractTasksModelIface methods to source model.

davidedmundson updated this object.

davidedmundson edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

hein added inline comments.

libtaskmanager/abstracttasksproxymodeliface.h
164	"Specified virtual activities"? (I can't tell if this is actually broken or the diff viewer screwing up.)

Synced comments

Needs merge coordination with D2391

This revision is now accepted and ready to land.Aug 12 2016, 9:23 AM

This revision was automatically updated to reflect the committed changes.

		Path
M		libtaskmanager/CMakeLists.txt (1 line)
P		libtaskmanager/abstracttasksproxymodeliface.h (76 lines) Copied from libtaskmanager/concatenatetasksproxymodel.h
A	M	libtaskmanager/abstracttasksproxymodeliface.cpp (225 lines)
P		libtaskmanager/concatenatetasksproxymodel.h (158 lines) Copied to libtaskmanager/abstracttasksproxymodeliface.h
M		libtaskmanager/concatenatetasksproxymodel.cpp (239 lines)
M		libtaskmanager/flattentaskgroupsproxymodel.h (156 lines)
M		libtaskmanager/flattentaskgroupsproxymodel.cpp (104 lines)
M		libtaskmanager/taskfilterproxymodel.h (158 lines)
M		libtaskmanager/taskfilterproxymodel.cpp (107 lines)
M		libtaskmanager/windowtasksmodel.h (123 lines)
M		libtaskmanager/windowtasksmodel.cpp (104 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5768	b58f6ee		Aug 9 2016, 11:22 AM	★	★
Diff 2	5795	b58f6ee	Synced comments	Aug 10 2016, 10:52 AM	★	★
Diff 3	5877	1787272	rPLASMAWORKSPACE9413404fb29e6f57ac85a86453647dd9a9a6fd5b	Aug 12 2016, 1:32 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
dcac9a3ea929	bc22161970b1	b58f6ee2a3c5	David Edmundson	Share logic for passing AbstractTasksModelIface methods to source model (Show More…)	Aug 9 2016, 11:16 AM