[Libtaskmanager] Add "requestOpenUrls" to open given URLs with the associated application
ClosedPublic

Authored by broulik on Aug 10 2016, 10:32 AM.

Details

Test Plan

Wayland untested but compiled.

(btw, serviceCache.contains and then serviceCache.value performs a double lookup, QHash value returns a default-constructed value for not found entries, so could probably be simplified to?

KService::Ptr service = serviceCache.value(window);
if (service) {
    // ...
}

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 5793.Aug 10 2016, 10:32 AM
broulik retitled this revision from to [Libtaskmanager] Add "requestOpenUrls" to open given URLs with the associated application.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 10 2016, 10:32 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein added a subscriber: hein.Aug 12 2016, 9:22 AM
hein added inline comments.
libtaskmanager/abstracttasksmodel.h
119

Missing period, also elsewhere

121

s/The/This/

124

Missing period, also elsewhere

libtaskmanager/concatenatetasksproxymodel.h
72

Remove

libtaskmanager/flattentaskgroupsproxymodel.h
75

Remove

libtaskmanager/launchertasksmodel.cpp
324

Use KWindowSystem::isPlatformX11()

libtaskmanager/taskfilterproxymodel.h
254

Remove

libtaskmanager/taskgroupingproxymodel.h
218

Remove

libtaskmanager/tasksmodel.h
583

Remove

libtaskmanager/waylandtasksmodel.cpp
386

const

libtaskmanager/xwindowtasksmodel.cpp
955

const I think

broulik updated this revision to Diff 5863.Aug 12 2016, 9:52 AM
  • Throw a bunch of full stops at the code
  • Remove copy-paste error about base impl that does nothing
  • Use KWindowSystem::isPlatformX11
hein accepted this revision.Aug 12 2016, 10:21 AM
hein added a reviewer: hein.
This revision is now accepted and ready to land.Aug 12 2016, 10:21 AM
This revision was automatically updated to reflect the committed changes.