| fvogt | |
| ognarb |
| Plasma |
Noticed that I got title changes sent to the extension every time
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| extension/content-script.js | ||
|---|---|---|
| 333 | Why not document.title? | |
| extension/content-script.js | ||
|---|---|---|
| 333 | This is to store the name and only send a change when it is different from last time I sent it. document.title will be the same as titleTag.innerText rendering this check moot | |
| extension/content-script.js | ||
|---|---|---|
| 333 | No, it won't be. Currently it won't send a notification if the title changes to an empty string as document.title was sent initially (line 319) | |
| extension/content-script.js | ||
|---|---|---|
| 333 | An empty title is kinda pointless anyway, so this is on purpose | |
| extension/content-script.js | ||
|---|---|---|
| 333 | It would still send an empty title on initialization or changes after the first change though. So if that's the purpose of the empty string assignment, it should be done differently. | |