Differential D23772

Make less use of deprecated enum alias NET::StaysOnTop
ClosedPublic
Actions

Authored by kossebau on Sep 7 2019, 12:47 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R278:c747c71d7146: Make less use of deprecated enum alias NET::StaysOnTop
Summary
  • use NET::KeepAbove instead of NET::StaysOnTop in code
  • deduplicate code handling the value of NET::KeepAbove/NET::StaysOnTop
  • remove mention of NET::StaysOnTop in API dox where just alias

Diff Detail

Repository
R278 KWindowSystem
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Sep 7 2019, 12:47 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 7 2019, 12:47 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Sep 7 2019, 12:47 PM
kossebau added a comment.Sep 7 2019, 12:52 PM

Found while experimenting with code for T11490.

This patch would later allow to do a simple

#if KWINDOWSYSTEM_ENABLE_DEPRECATED_SINCE(5, 0)
          /**
             @deprecated This is an obsolete name for KeepAbove.
          **/
          StaysOnTop   = KeepAbove,   // NOT STANDARD
#endif

to hide the enum alias on demand, without breaking the build of kwindowsystem itself

zzag edited reviewers, added: KWin; removed: Frameworks.Sep 7 2019, 12:58 PM
zzag accepted this revision.Sep 7 2019, 1:37 PM
This revision is now accepted and ready to land.Sep 7 2019, 1:37 PM
zzag added inline comments.Sep 7 2019, 1:40 PM
autotests/netwininfotestwm.cpp
449 ↗(On Diff #65574)

We can remove this row now.

kossebau added a comment.Sep 7 2019, 1:57 PM

@zzag: Thanks for review. Will land once KF 5.62 is branched this WE.

autotests/netwininfotestwm.cpp
449 ↗(On Diff #65574)

Indeed, does the same test as the row above, good catch, Will remove then.

Closed by commit R278:c747c71d7146: Make less use of deprecated enum alias NET::StaysOnTop (authored by kossebau). · Explain WhySep 7 2019, 10:27 PM
This revision was automatically updated to reflect the committed changes.
kossebau marked an inline comment as done.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Mautotests/netwininfotestwm.cpp (1 line)

Diff 65613

View Options

autotests/netwininfotestwm.cpp

Loading...