Differential D23765

Implement deleting a contact
ClosedPublic
Actions

Authored by jbbgameich on Sep 7 2019, 9:51 AM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Commits

R732:8207754733da: Implement deleting a contact

Summary

Depends on D23764

Diff Detail

Repository

R732 KPeople VCard Support

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

jbbgameich requested review of this revision.Sep 7 2019, 9:51 AM

jbbgameich created this revision.

Harbormaster completed remote builds in B16204: Diff 65556.Sep 7 2019, 9:51 AM

jbbgameich edited the summary of this revision. (Show Details)Sep 7 2019, 9:51 AM

jbbgameich added a dependency: D23764: Make it possible to delete contacts from backends.

sorry, forgot to add the reviewers initially. That's fixed now.

LGTM otherwise.

src/kpeoplevcard.cpp
135	Use m_location.
244	Separate patch, no need to review.

Revert unrelated change

Harbormaster completed remote builds in B16216: Diff 65584.Sep 7 2019, 3:42 PM

apol added inline comments.Sep 7 2019, 3:59 PM

src/kpeoplevcard.cpp
135	ping?

jbbgameich added inline comments.Sep 7 2019, 11:18 PM

src/kpeoplevcard.cpp
135	Sorry, I don't really understand what you mean by this. m_location is only a member of the VCardContact class, not of the VCardDataSource class.

apol added a comment.Sep 8 2019, 7:55 AM

This comment was removed by apol.

apol accepted this revision.Sep 8 2019, 7:56 AM

apol added inline comments.

src/kpeoplevcard.cpp
135	We could look-up the item and get the location. Hm. I guess as is it's cheaper and works for now.

This revision is now accepted and ready to land.Sep 8 2019, 7:56 AM

Landing it because I need it for something I'm working on.

Closed by commit R732:8207754733da: Implement deleting a contact (authored by jbbgameich, committed by apol). · Explain WhySep 8 2019, 2:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/kpeoplevcard.h (1 line)
M			src/kpeoplevcard.cpp (8 lines)

Diff 65652

src/kpeoplevcard.h

Loading...

src/kpeoplevcard.cpp

Loading...