utils: Port away from foreach loops over members without calls to owner
ClosedPublic

Authored by kossebau on Sep 3 2019, 1:54 PM.

Details

Summary

There is some small risk here:

  • overseen call chains which still call the owner and modify the container
  • other threads might access the same containers, even if class is not designed to be thread-safe, but wrong usages are currently caught mostly by the container copy

GIT_SILENT

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Sep 3 2019, 1:54 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSep 3 2019, 1:54 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
kossebau requested review of this revision.Sep 3 2019, 1:54 PM
dhaumann accepted this revision.Sep 4 2019, 5:28 AM
dhaumann added a subscriber: dhaumann.

Lgtm, please commit.

This revision is now accepted and ready to land.Sep 4 2019, 5:28 AM
This revision was automatically updated to reflect the committed changes.