Differential D23700

view: Port away from foreach loops over members without calls to owner
ClosedPublic
Actions

Authored by kossebau on Sep 3 2019, 1:42 PM.

Details

Reviewers
dhaumann
Group Reviewers
Kate
Commits
R39:d35377978a90: view: Port away from foreach loops over members without calls to owner
Summary

There is some small risk here:

  • overseen call chains which still call the owner and modify the container
  • other threads might access the same containers, even if class is not designed to be thread-safe, but wrong usages are currently caught mostly by the container copy

GIT_SILENT

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Sep 3 2019, 1:42 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSep 3 2019, 1:42 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
kossebau requested review of this revision.Sep 3 2019, 1:42 PM
dhaumann accepted this revision.Sep 4 2019, 5:31 AM
This revision is now accepted and ready to land.Sep 4 2019, 5:31 AM
Closed by commit R39:d35377978a90: view: Port away from foreach loops over members without calls to owner (authored by kossebau). · Explain WhySep 8 2019, 1:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/view/kateview.cpp (3 lines)
Msrc/view/kateviewinternal.cpp (2 lines)

Diff 65618

View Options

src/view/kateview.cpp

Loading...
View Options

src/view/kateviewinternal.cpp

Loading...