Differential D23699

mode: Port away from foreach loops over members without calls to owner
ClosedPublic
Actions

Authored by kossebau on Sep 3 2019, 1:40 PM.

Details

Reviewers
cullmann
Group Reviewers
Kate
Commits
R39:2d582d7f8d46: mode: Port away from foreach loops over members without calls to owner
Summary

There is some small risk here:

  • overseen call chains which still call the owner and modify the container
  • other threads might access the same containers, even if class is not designed to be thread-safe, but wrong usages are currently caught mostly by the container copy

GIT_SILENT

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Sep 3 2019, 1:40 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSep 3 2019, 1:40 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
kossebau requested review of this revision.Sep 3 2019, 1:40 PM
cullmann accepted this revision.Sep 3 2019, 4:49 PM
cullmann added a subscriber: cullmann.

That looks sane for me.
If there are threads this will all break into parts, there is no need to care for that (the shared containers are then not the real issue).

This revision is now accepted and ready to land.Sep 3 2019, 4:49 PM
Closed by commit R39:2d582d7f8d46: mode: Port away from foreach loops over members without calls to owner (authored by kossebau). · Explain WhySep 8 2019, 12:57 AM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 65617