[libnotificatonmanager] Initialise member variable
ClosedPublic

Authored by davidedmundson on Sep 2 2019, 5:24 PM.

Details

Summary

1408== Conditional jump or move depends on uninitialised value(s)

1408== at 0x1F0D8A6D:

NotificationManager::NotificationGroupCollapsingProxyModel::setLimit(int)
(src/kde/workspace/plasma-workspace/libnotificationmanager/notificationgroupcollapsingproxymodel.cpp:112)

1408== by 0x1F0BA091:

NotificationManager::Notifications::Private::initProxyModels()
(src/kde/workspace/plasma-workspace/libnotificationmanager/notifications.cpp:227)

1408== by 0x1F0BBC75:

NotificationManager::Notifications::setGroupMode(NotificationManager::Notifications::GroupMode)
(src/kde/workspace/plasma-workspace/libnotificationmanager/notifications.cpp:584)

1408== by 0x1F09F7B2:

NotificationManager::Notifications::qt_static_metacall(QObject*,
QMetaObject::Call, int, void**) (moc_notifications.cpp:668)

Practical impact is limited as every user has to call setLimit anyway

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16018
Build 16036: arc lint + arc unit
davidedmundson created this revision.Sep 2 2019, 5:24 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 2 2019, 5:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Sep 2 2019, 5:24 PM
broulik accepted this revision.Sep 2 2019, 6:05 PM
This revision is now accepted and ready to land.Sep 2 2019, 6:05 PM
This revision was automatically updated to reflect the committed changes.