Lower the log level for when the mimeFromContent differed from MimeFromExtension
ClosedPublic

Authored by meven on Aug 31 2019, 7:10 AM.

Details

Summary

This makes ark less noisy in logs, since this message can be frequent and can be considered as info rather than a warning.
Warning log example :
ark.kerfuffle: Mimetype for filename extension ( "text/x-cmake" ) did not match mimetype for content ( "text/plain" ). Using content-based mimetype.

Diff Detail

Repository
R36 Ark
Branch
arcpatch-D23599
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16042
Build 16060: arc lint + arc unit
meven created this revision.Aug 31 2019, 7:10 AM
Restricted Application added a project: Ark. · View Herald TranscriptAug 31 2019, 7:10 AM
Restricted Application added subscribers: Ark, kde-utils-devel. · View Herald Transcript
meven requested review of this revision.Aug 31 2019, 7:10 AM

Hmm, this is categorized logging which means if you are seeing that message you have explicitly enabled ark logging.

That said, I can agree that qCWarning is maybe too much, but then I'd use qCDebug. We never use qCInfo in ark.

meven updated this revision to Diff 65303.Sep 3 2019, 10:21 AM

Use qCDebug instead of qCInfo

elvisangelaccio accepted this revision.Sep 9 2019, 8:57 AM
This revision is now accepted and ready to land.Sep 9 2019, 8:57 AM
This revision was automatically updated to reflect the committed changes.