Make battery serial property constant
ClosedPublic

Authored by meven on Aug 31 2019, 7:01 AM.

Details

Summary

Since serial property cannot change and has no NOTIFY function, mark it as constant, to avoid warnings when the property is used in qml expression.
For instance in kinfocenter energy_info kcm :

QQmlExpression: Expression file:///home/meven/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/main.qml:452:29 depends on non-NOTIFYable properties:
    Solid::Battery::serial

Diff Detail

Repository
R245 Solid
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Aug 31 2019, 7:01 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 31 2019, 7:01 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Aug 31 2019, 7:01 AM
meven edited the summary of this revision. (Show Details)Aug 31 2019, 7:02 AM
davidedmundson accepted this revision.Aug 31 2019, 7:37 AM
This revision is now accepted and ready to land.Aug 31 2019, 7:37 AM
This revision was automatically updated to reflect the committed changes.