Avoid overloading KCModule::changed
ClosedPublic

Authored by davidedmundson on Aug 27 2019, 8:38 PM.

Details

Summary

KCModule contains a signal and a protected slot with the same name.
With the new connect syntax this becomes messy, especially as
this method is called from KCMs a lot.

This patch introduces a new name for the slot, with the
intention of dropping the old one in KF6

Diff Detail

Repository
R265 KConfigWidgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Aug 27 2019, 8:38 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 27 2019, 8:38 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Aug 27 2019, 8:38 PM
apol added a subscriber: apol.Aug 28 2019, 12:17 AM

+1

src/kcmodule.h
382–388

Use KCONFIGWIDGETS_DEPRECATED?

add KCONFIGWIDGETS_DEPRECATED

apol accepted this revision.Oct 1 2019, 10:29 AM
This revision is now accepted and ready to land.Oct 1 2019, 10:29 AM
This revision was automatically updated to reflect the committed changes.