Remove NX support
AcceptedPublic

Authored by adridg on Aug 25 2019, 7:46 PM.

Details

Reviewers
uwolfer
Summary

Although NX still exists, and nomachine.com offers downloads for
Linux, the NX plugin for krdc was never updated since KDE 4.2.
Let's call 8 years with no development a "unused, remove" kind of feature.

Test Plan

The top-level CMakeLists.txt had the check for NX commented out,
and the sub-CMakeLists.txt checked for a _FOUND that couldn't
possibly be set.

Diff Detail

Repository
R436 KRDC
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15631
Build 15649: arc lint + arc unit
adridg requested review of this revision.Aug 25 2019, 7:46 PM
adridg created this revision.
aacid added a comment.Aug 25 2019, 8:07 PM

I don't have a strong opinion, but personally i'd leave it since i don't see it hurting us, but if we're going to remove it maybe we can add a note somewhere in the code/readme/cmakelists saying something like "if you're going to write some NX code please see the old code that was removed in case it can be of help"

uwolfer accepted this revision.Aug 26 2019, 5:46 PM

I'm fine with dropping it as it is dead code. Please add a note to the ticket with the commit # after merging this: https://bugs.kde.org/show_bug.cgi?id=149482

This revision is now accepted and ready to land.Aug 26 2019, 5:46 PM