Differential D23444

Remove applets/22/computer
ClosedPublic
Actions

Authored by ndavis on Aug 25 2019, 2:15 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Commits
R266:ffeabe765df8: Revert "Add breeze icons for ROOT cern files"
R266:fff83c41653a: Remove applets/22/computer
Summary

BUG: 410854

It's also unnecessary because it's just a symlink to another 22px icon with the same exact name.

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Aug 25 2019, 2:15 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 25 2019, 2:15 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Aug 25 2019, 2:15 PM
ndavis edited the summary of this revision. (Show Details)Aug 25 2019, 2:16 PM
ndavis edited the summary of this revision. (Show Details)
ngraham added a subscriber: ngraham.Aug 25 2019, 3:25 PM

Are you sure this fixes the issue? I tried out the patch and deleted the removed files manually, but it didn't make a difference.

ndavis added a comment.EditedAug 25 2019, 11:58 PM
In D23444#518948, @ngraham wrote:

Are you sure this fixes the issue? I tried out the patch and deleted the removed files manually, but it didn't make a difference.

Yes, but verifying the fix is a little tricky. Possibly because of cache. I got it to work by deleting /usr/share/icons/breeze/applets/22/computer.svg and /usr/share/icons/breeze-dark/applets/22/computer.svg, which is the end result after distributing this patch.

ngraham accepted this revision.Aug 26 2019, 3:23 PM

Ah, I see now. Confirmed that this fixes the issue. Nice catch!

This revision is now accepted and ready to land.Aug 26 2019, 3:23 PM
Closed by commit R266:fff83c41653a: Remove applets/22/computer (authored by ndavis). · Explain WhyAug 26 2019, 6:26 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 64692