The start row for the drag is set to the current index but the current index is not always the item being dragged. This is because syncTarget has not been called yet to update the current index to the item under the cursor. Fix this by calling syncTarget before reading the current index.
Details
Details
- Reviewers
broulik bshah - Group Reviewers
Plasma - Commits
- R119:5eaadb75de3d: [Kickoff] Fix start row for drag not always being correct
Drag items around and notice that the item being moved is not always correct.
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
There's still something off when I drag a bottom favorite to the top if often ends up in the wrong place or doesn't move at all. This is with and without this patch, so looks good to me. For 5.8 where I reworked the drag-drop stuff I'll look if this is still the case and fix it. :)