Differential D2322

[Kickoff] Fix start row for drag not always being correct
ClosedPublic
Actions

Authored by net147 on Aug 1 2016, 2:02 AM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R119:6b8b17897664: [Kickoff] Fix start row for drag not always being correct
Summary

The start row for the drag is set to the current index but the current index is not always the item being dragged. This is because syncTarget has not been called yet to update the current index to the item under the cursor. Fix this by calling syncTarget before reading the current index.

Test Plan

Drag items around and notice that the item being moved is not always correct.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
net147 updated this revision to Diff 5591.Aug 1 2016, 2:02 AM
net147 retitled this revision from to [Kickoff] Fix start row for drag not always being correct.
net147 updated this object.
net147 edited the test plan for this revision. (Show Details)
net147 added reviewers: Plasma, broulik.
net147 set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 1 2016, 2:02 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Aug 2 2016, 7:16 AM
broulik edited edge metadata.
This revision is now accepted and ready to land.Aug 2 2016, 7:16 AM
Closed by commit R119:6b8b17897664: [Kickoff] Fix start row for drag not always being correct (authored by net147, committed by bshah). · Explain WhyAug 2 2016, 7:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5624

View Options

applets/kickoff/package/contents/ui/FavoritesView.qml

Loading...